-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing VectorSumCombiner #276
Implementing VectorSumCombiner #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It looks good, I left comments
Add error handling to AggregateParams Update tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It looks great. Just a few minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Following the first item described in #264, this PR has the implementation of the
VectorSumCombiner
class, which should be used to compute vector/array sums.Affected Dependencies
Needed to extend AggregateParams with the fields
norm_kind
andmax_norm
.How has this been tested?
combiners_test.py
Checklist